Fix split() pivoting to avoid stack overflow from Quicksort worst case. #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flow.
One such case is 'A' * 1048575 + 'B' + 'A' * 1048575 + 'C'. Demo:
gcc -DBSDIFF_EXECUTABLE bsdiff.c -lbz2 -o bsdiff
perl -e "print('A'x1048575,'B','A'x1048575,'C')" > big
./bsdiff big big patch
Output before patch: 'Segmentation fault (core dumped)'.
Output after patch: No crash, outputs 85 byte file 'patch'.
Details: http://crbug.com/605565#c11
lalawue
added a commit
to lalawue/bsdiff
that referenced
this pull request
Sep 30, 2021
edcdecl
added a commit
to edcdecl/bsdiff
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One such case is 'A' * 1048575 + 'B' + 'A' * 1048575 + 'C'. Demo:
gcc -DBSDIFF_EXECUTABLE bsdiff.c -lbz2 -o bsdiff
perl -e "print('A'x1048575,'B','A'x1048575,'C')" > big
./bsdiff big big patch
Output before patch: 'Segmentation fault (core dumped)'.
Output after patch: No crash, outputs 85 byte file 'patch'.
Details: http://crbug.com/605565#c11